Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 563172a

Browse files
committedJul 13, 2013
rustpkg: Address review comments from cmr
1 parent 1a46afb commit 563172a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
 

‎src/librustpkg/installed_packages.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use std::os;
1515

1616
pub fn list_installed_packages(f: &fn(&PkgId) -> bool) -> bool {
1717
let workspaces = rust_path();
18-
for workspaces.iter().advance() |p| {
18+
for workspaces.iter().advance |p| {
1919
let binfiles = os::list_dir(&p.push("bin"));
2020
for binfiles.iter().advance() |exec| {
2121
f(&PkgId::new(*exec));
@@ -30,7 +30,7 @@ pub fn list_installed_packages(f: &fn(&PkgId) -> bool) -> bool {
3030

3131
pub fn package_is_installed(p: &PkgId) -> bool {
3232
let mut is_installed = false;
33-
let _ = do list_installed_packages() |installed| {
33+
do list_installed_packages() |installed| {
3434
if installed == p {
3535
is_installed = true;
3636
}

‎src/librustpkg/testsuite/pass/src/install-paths/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ use lib::f;
2424
mod lib;
2525

2626
fn main() {
27-
let _ = f();
27+
f();
2828
}

5 commit comments

Comments
 (5)

bors commented on Jul 13, 2013

@bors
Collaborator

saw approval from catamorphism
at catamorphism@563172a

bors commented on Jul 13, 2013

@bors
Collaborator

merging catamorphism/rust/rustpkg-list-uninstall = 563172a into auto

bors commented on Jul 13, 2013

@bors
Collaborator

catamorphism/rust/rustpkg-list-uninstall = 563172a merged ok, testing candidate = 72385df1

bors commented on Jul 14, 2013

@bors
Collaborator

No active merge of candidate 563172a found, likely manual push to master

bors commented on Jul 14, 2013

@bors
Collaborator

merging catamorphism/rust/rustpkg-list-uninstall = 563172a into auto

Please sign in to comment.