Skip to content

missing generic_associated_types stabilisation version? #101766

@matthiaskrgr

Description

@matthiaskrgr
Member
#![feature(generic_associated_types)]
pub fn main() {}

with rustc master rustc 1.65.0-nightly (5338f5f1d 2022-09-13)

warning: the feature `generic_associated_types` has been stable since CURRENT_RUSTC_VERSION and no longer requires an attribute to enable
 --> f.rs:1:12
  |
1 | #![feature(generic_associated_types)]
  |            ^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(stable_features)]` on by default

warning: 1 warning emitted

looks like the stabilisation version is borked? 😅
cc @jackh726

Activity

jackh726

jackh726 commented on Sep 13, 2022

@jackh726
Member

This is correct, but not ideal: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#updating-the-feature-gate-listing

cc @est31 maybe we want to special case this in the diagnostics

est31

est31 commented on Sep 13, 2022

@est31
Member

Yeah seems I've missed correcting that lint. For GATs, the stabilization version will be adjusted very soon, in the coming days, as we are close to the release cycle. But this needs to be fixed for future stabilizations as well. Working on a PR. @rustbot label bug

rustbot

rustbot commented on Sep 13, 2022

@rustbot
Collaborator

Error: Label bug can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

est31

est31 commented on Sep 13, 2022

@est31
Member

Yeah it warns correctly for lib features so only lang features are affected:

warning: the feature `io_read_to_string` has been stable since 1.65.0-nightly and no longer requires an attribute to enable
 --> src/main.rs:1:12
  |
1 | #![feature(io_read_to_string)]
  |            ^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(stable_features)]` on by default
est31

est31 commented on Sep 13, 2022

@est31
Member

PR filed: #101772

added a commit that references this issue on Sep 14, 2022
94bc08d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @matthiaskrgr@est31@jackh726@rustbot

      Issue actions

        missing `generic_associated_types` stabilisation version? · Issue #101766 · rust-lang/rust