You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
with rustc master rustc 1.65.0-nightly (5338f5f1d 2022-09-13)
warning: the feature `generic_associated_types` has been stable since CURRENT_RUSTC_VERSION and no longer requires an attribute to enable
--> f.rs:1:12
|
1 | #![feature(generic_associated_types)]
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(stable_features)]` on by default
warning: 1 warning emitted
looks like the stabilisation version is borked? 😅
cc @jackh726
Yeah seems I've missed correcting that lint. For GATs, the stabilization version will be adjusted very soon, in the coming days, as we are close to the release cycle. But this needs to be fixed for future stabilizations as well. Working on a PR. @rustbot label bug
Yeah it warns correctly for lib features so only lang features are affected:
warning: the feature `io_read_to_string` has been stable since 1.65.0-nightly and no longer requires an attribute to enable
--> src/main.rs:1:12
|
1 | #![feature(io_read_to_string)]
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(stable_features)]` on by default
Activity
matthiaskrgr commentedon Sep 13, 2022
Hm, it actually says it like this in the code :D
https://github.com/rust-lang/rust/pull/96709/files#diff-307e0d3a2037c11a3fa16822fbaa0fec08e57ac7d0d6e7354f6005c9482a9e26R165
jackh726 commentedon Sep 13, 2022
This is correct, but not ideal: https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#updating-the-feature-gate-listing
cc @est31 maybe we want to special case this in the diagnostics
est31 commentedon Sep 13, 2022
Yeah seems I've missed correcting that lint. For GATs, the stabilization version will be adjusted very soon, in the coming days, as we are close to the release cycle. But this needs to be fixed for future stabilizations as well. Working on a PR. @rustbot label bug
rustbot commentedon Sep 13, 2022
Error: Label bug can only be set by Rust team members
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.
est31 commentedon Sep 13, 2022
Yeah it warns correctly for lib features so only lang features are affected:
est31 commentedon Sep 13, 2022
PR filed: #101772
Rollup merge of rust-lang#101772 - est31:replace_placeholder_diagnost…