Skip to content

Delete the stage1 and stage0-sysroot directories when using download-rustc #102002

Closed
@jyn514

Description

@jyn514
Member

@camelid: I just ran into something confusing with download-rustc: normal x.py build will build rustdoc and put it in stage1. However, x.py build with download-rustc enabled will put it in stage2. This means that rustdoc +stage1 ... won't run my local, modified version of rustdoc if download-rustc is set. Specifically, rustdoc +stage1 ... seems to run nightly rustdoc (or something static).

@bjorn3 suggests deleting the stage1 and stage0-sysroot directories when using download-rustc, to avoid caching issues like this. rustdoc +stage1 still won't do the right thing, but it will at least give a hard error instead of silently using the wrong version.

Originally posted by @jyn514 in #81930 (comment)

Activity

added
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
on Sep 19, 2022
jyn514

jyn514 commented on Sep 19, 2022

@jyn514
MemberAuthor
added
E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
on Sep 19, 2022
chenyukang

chenyukang commented on Sep 19, 2022

@chenyukang
Member

@rustbot claim

added a commit that references this issue on Sep 19, 2022

fix rust-lang#102002, Delete the stage1 and stage0-sysroot directorie…

973ff03
added a commit that references this issue on Oct 7, 2022

Auto merge of rust-lang#102025 - chenyukang:fix-102002, r=jyn514

e42c4d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-download-rustcArea: The `rust.download-rustc` build option.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @chenyukang@jyn514

    Issue actions

      Delete the `stage1` and `stage0-sysroot` directories when using download-rustc · Issue #102002 · rust-lang/rust