Closed
Description
@camelid: I just ran into something confusing with
download-rustc
: normalx.py build
will build rustdoc and put it in stage1. However,x.py build
withdownload-rustc
enabled will put it in stage2. This means thatrustdoc +stage1 ...
won't run my local, modified version of rustdoc ifdownload-rustc
is set. Specifically,rustdoc +stage1 ...
seems to run nightly rustdoc (or something static).
@bjorn3 suggests deleting the stage1
and stage0-sysroot
directories when using download-rustc, to avoid caching issues like this. rustdoc +stage1
still won't do the right thing, but it will at least give a hard error instead of silently using the wrong version.
Originally posted by @jyn514 in #81930 (comment)
Metadata
Metadata
Assignees
Labels
Area: The `rust.download-rustc` build option.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Activity
jyn514 commentedon Sep 19, 2022
Mentoring instructions: in https://github.com/rust-lang/rust/blob/405f0c21608cb41aabc512eed73b2ff707391cab/src/bootstrap/compile.rs#L1115-L1126 delete the sysroots
stage1
andstage0-sysroot
folders, not just the current sysroot.Some background info: https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html#what-is-a-sysroot
chenyukang commentedon Sep 19, 2022
@rustbot claim
fix rust-lang#102002, Delete the stage1 and stage0-sysroot directorie…
Auto merge of rust-lang#102025 - chenyukang:fix-102002, r=jyn514