-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-clippyArea: ClippyArea: ClippyA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.Call for participation: Hard difficulty. Experience needed to fix: A lot.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
Clippy is a special snowflake and uses TESTNAME
to tell it how to run individual tests instead of an argument to compiletest. Currently the only way to run individual tests is with TESTNAME=ice-6250 x test src/tools/clippy --bless
. We should support x test src/tools/clippy/tests/ice-6250.rs
as well.
#103266 will help simplify this a little by supporting the same test arguments as in-tree compiletest, but it won't solve suite paths automatically. Suite code lives around https://github.com/rust-lang/rust/blob/51de2387dc8b0871a7bbb58f0c73ea7ca1d339e4/src/bootstrap/builder.rs#L480 - maybe we need to change impl Step for Clippy
to use suite_path
?
Originally posted by @jyn514 in #103636 (comment)
Metadata
Metadata
Assignees
Labels
A-clippyArea: ClippyArea: ClippyA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.Call for participation: Hard difficulty. Experience needed to fix: A lot.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
est31 commentedon Nov 10, 2022
FTR this is also badly documented in clippy itself. You can't find it in the contributor instructions for example. It's also not printed by compiletest when it says "if you want to re-run the test do X" (that gives you a wrong command).
jyn514 commentedon Nov 10, 2022
@est31 you should report that on the clippy repo.
est31 commentedon Nov 10, 2022
@jyn514 fair. Done: rust-lang/rust-clippy#9825
reez12g commentedon Jan 3, 2023
@rustbot claim
jieyouxu commentedon Feb 19, 2025
Triage: clippy no longer uses compiletest (it uses
ui_test
now I think), but still usesTESTNAME
.jieyouxu commentedon Feb 22, 2025
IIRC
suite_path
is only really meant for compiletest, and this might be tricky because clippy isn't using compiletest.Shourya742 commentedon Feb 28, 2025
@rustbot claim
xtexx commentedon May 24, 2025
@rustbot claim
bootstrap: clippy: set TESTNAME based on given paths
bootstrap: clippy: set TESTNAME based on given paths
bootstrap: clippy: set TESTNAME based on given paths
Rollup merge of rust-lang#141508 - xtexx:rust-langgh-104200, r=onur-o…
Unrolled build for #141508