Skip to content

rustdoc: regression: macro_export in doc(hidden) mod disappears #108231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #12
Nugine opened this issue Feb 19, 2023 · 2 comments · Fixed by #108241
Closed
Tracked by #12

rustdoc: regression: macro_export in doc(hidden) mod disappears #108231

Nugine opened this issue Feb 19, 2023 · 2 comments · Fixed by #108241
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Nugine
Copy link
Contributor

Nugine commented Feb 19, 2023

Code

I tried this code:

#[doc(hidden)]
pub mod __internal {
    /// Foooooo
    #[macro_export]
    macro_rules! foo {
        () => {};
    }
}

I expected to see this happen:
expected.png

Instead, this happened:
happened.png

Version it worked on

It most recently worked on: Rust 1.67.1, Rust nightly-2023-02-03

rustc 1.69.0-nightly (f3126500f 2023-02-02)
binary: rustc
commit-hash: f3126500f25114ba4e0ac3e76694dd45a22de56d
commit-date: 2023-02-02
host: x86_64-unknown-linux-gnu
release: 1.69.0-nightly
LLVM version: 15.0.7

Version with regression

Rust nightly-2023-02-04

rustc --version --verbose:

rustc 1.69.0-nightly (658fad6c5 2023-02-03)
binary: rustc
commit-hash: 658fad6c5506f41c35b64fb1a22ceb0992697ff3
commit-date: 2023-02-03
host: x86_64-unknown-linux-gnu
release: 1.69.0-nightly
LLVM version: 15.0.7

@rustbot modify labels: +regression-from-stable-to-nightly -regression-untriaged

@Nugine Nugine added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Feb 19, 2023
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. and removed regression-untriaged Untriaged performance or correctness regression. labels Feb 19, 2023
@Nugine Nugine mentioned this issue Feb 19, 2023
6 tasks
@fmease
Copy link
Member

fmease commented Feb 19, 2023

Very likely regressed in #108057 (CC @GuillaumeGomez).

@rustbot label T-rustdoc

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 19, 2023
@GuillaumeGomez
Copy link
Member

So macros should be excluded from the inheritance as well. Sending a fix.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 20, 2023
@bors bors closed this as completed in 52fa8fe Feb 21, 2023
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants