Tracking Issue for ip_in_core

[joshtriplett]

Feature gate: #![feature(ip_in_core)]

This is a tracking issue for RFC rust-lang/rfcs#2832, providing networking types in core::net: IpAddr, Ipv4Addr, Ipv6Addr, SocketAddr, SocketAddrV4, SocketAddrV6, Ipv6MulticastScope and AddrParseError.

Steps / History

• Implementation: Move IpAddr, SocketAddr and V4+V6 related types to core #104265
• Final comment period (FCP)¹
• Stabilization PR: Stabilize ip_in_core feature #119276

Footnotes

1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩

[elpiel]

I guess there's nothing left to do.
Can this feature now move to the the FCP?

[Xiretza]

Can this be stabilized before error_in_core (AddrParseError implements core::error::Error)?

[elpiel]

Can this be stabilized before error_in_core (AddrParseError implements core::error::Error)?

I believe so.

• Nothing in ip_addr points or uses core::error::Error:

https://github.com/faern/rust/blob/1291216ac986ccc1432bf0bf2db9545e5251dd24/library/core/src/net/ip_addr.rs
(master) https://github.com/rust-lang/rust/blob/master/library/core/src/net/ip_addr.rs

• The only impl Error is in Parser and I guess it needs to be featured gated: https://github.com/rust-lang/rust/blob/master/library/core/src/net/parser.rs#L485-L498

[Nemo157]

You can't feature gate a trait implementation. The question would be if it's possible to refer to any of the trait Error methods on the error types without having to activate the feature. I believe not, since you would have to use core::error::Error in order to bring the methods into scope.

[elpiel]

Thanks for the explanation @Nemo157 and yes, I agree that it can't be stabilised before Error then.