Skip to content

#115269 broke builds in Fuchsia #115852

Closed
Closed
@djkoloski

Description

@djkoloski

We just hit a CI failure in Fuchsia due to #115269 which corrected name resolution ordering for macro-expanded items. This change can break semver for crates. This change probably deserves a crater run to evaluate ecosystem impact, even if the old behavior is incorrect.

Activity

added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Sep 14, 2023
Urgau

Urgau commented on Sep 15, 2023

@Urgau
Member

Would you happen to have a minimal test case? or something we can reproduce?

Also there was a crater run: #115269 (comment)

@rustbot label +T-compiler +E-needs-mcve +regression-untriaged -needs-triage
cc @bvanjoi

added
E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
regression-untriagedUntriaged performance or correctness regression.
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
and removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Sep 15, 2023
Noratrieb

Noratrieb commented on Sep 15, 2023

@Noratrieb
Member

I don't quite understand what you mean with "broke semver". Do you mean that it broke Fuchsias build? Or that it changes behavior? Not sure what this has to do with semver, no new releases of crates are being made.

djkoloski

djkoloski commented on Sep 15, 2023

@djkoloski
ContributorAuthor

Sorry for the confusion @Nilstrieb . I say "broke semver" in the sense of changing the API surface in a way that we were able to observe (our build broke). That's mostly based on @obi1kenobi's efforts to track down unexpected semver violations, which has also found a lot of pre-existing problems with glob imports. It's probably not the best terminology for this situation, sorry for the confusion.

We got lucky in the sense that it was just a compiler error instead of a functionality change. I wanted to raise the issue since it seemed unlikely that we were the only ones who observed breakage. The crater run confirms that other crates were affected, but I see now that there was discussion about whether those breakages were acceptable. Since that discussion has already happened, I'm going to close this issue.

changed the title [-]#115269 broke semver in Fuchsia[/-] [+]#115269 broke builds in Fuchsia[/+] on Sep 15, 2023
removed
E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
regression-untriagedUntriaged performance or correctness regression.
on Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Urgau@apiraino@djkoloski@rustbot@Noratrieb

        Issue actions

          #115269 broke builds in Fuchsia · Issue #115852 · rust-lang/rust