-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Closed
Description
To provide strict total ordering for semver::Version
, build metadata must be ignored for equality. Which way is preferred?
- Preserve build metadata in
Version
but equality checking ignores it.- Most of behaviors are preserved.
- Remove build metadata field from
Version
and the parser ignores it.format!("{}", parse("1.0.0+build.1").unwrap()) == "1.0.0"
cc #12435
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
erickt commentedon Feb 21, 2014
I we should keep the build data and exclude it from the equality and ordering check. That way we can convert a version back into a string.
omasanori commentedon Feb 21, 2014
@erickt Sure.
Auto merge of rust-lang#13789 - feniljain:fix_enum_completion, r=Veykril
Fix rust-lang#12438 false positive regression
Auto merge of rust-lang#12447 - MarcusGrass:mg/fix-12438-regression, …