Skip to content

compiletest: more consistent handling of bool-like env vars #125895

New issue
New issue
Open
Open
compiletest: more consistent handling of bool-like env vars#125895
Labels
A-compiletestArea: The compiletest test runnerC-cleanupCategory: PRs that clean code up or issues documenting cleanup.C-enhancementCategory: An issue proposing an enhancement or a PR with one.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
@jieyouxu

Description

@jieyouxu
jieyouxu
opened on Jun 2, 2024

Noticed in #125890 (comment).

It would be nice to have more consistent handling of what is considered "truthy" or "falsey" for env vars that accept a bool-ish value. In particular, if an env var's value contains invalid UTF-8, we probably should straight up error instead of silently parsing it as truthy/falsey?

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerC-cleanupCategory: PRs that clean code up or issues documenting cleanup.C-enhancementCategory: An issue proposing an enhancement or a PR with one.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions