-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Open
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
(Follow-up to #126180 and #126257.)
There are currently 5 tests that use the needs-force-clang-based-tests
header (formerly needs-matching-clang
):
tests/run-make/cross-lang-lto-clang/Makefile
(this one does actually run)tests/run-make/cross-lang-lto-pgo-smoketest/Makefile
tests/run-make/cross-lang-lto-riscv-abi/rmake.rs
tests/run-make/issue-84395-lto-embed-bitcode/Makefile
tests/run-make/wasm-override-linker/Makefile
Tests with this header only run when RUSTBUILD_FORCE_CLANG_BASED_TESTS
is set. That environment variable is only set in the x86_64-gnu-debug
job, and only when running x --stage 2 test tests/run-make --test-args clang
. So in practice, 4/5 of the above tests don't appear to ever run in any CI job.
@rustbot label +A-testsuite
jieyouxu
Metadata
Metadata
Assignees
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.