Skip to content

Delete all code for handling lldb and gdb versions that don't support Rust natively #128953

Closed
@saethlin

Description

@saethlin
Member

We have a fair bit of code in both src/tools/compiletest and tests/debuginfo devoted to handling the 7.X releases of gdb, because those had no built-in Rust support. But as of this year at least, the oldest supported RHEL version is now shipping gdb 8.2 so there's no reason for us to be pretending to support versions of gdb before 8.2.

The dev guide also vaguely indicates that this distinction for lldb shouldn't exist anymore:

https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L216
https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L253-L255

  • Delete all the gdbg annotations in tests/debuginfo, and convert all gdbr to just gdb
    Delete all the lldbg annotations in tests/debuginfo and convert all lldbr to lldb
    Check if the tests still pass (you've got a 50/50 shot on this, debuginfo tests are cursed)
    Delete the code in compiletest that handles this "Rust support" version gap for gdb, and for lldb

Activity

added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Aug 11, 2024
added
E-help-wantedCall for participation: Help is requested to fix this issue.
A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)
on Aug 11, 2024
added
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
A-compiletestArea: The compiletest test runner
on Aug 11, 2024
added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
and removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Aug 11, 2024
self-assigned this
on Aug 17, 2024
added 3 commits that reference this issue on Aug 18, 2024

Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=<try>

Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=<try>

Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=<try>

saethlin

saethlin commented on Aug 18, 2024

@saethlin
MemberAuthor

Turns out the modern side of the version split for lldb is the version without Rust support. That's a bummer, but still the goal here is to delete unused code.

removed
E-help-wantedCall for participation: Help is requested to fix this issue.
on Aug 18, 2024
added a commit that references this issue on Aug 19, 2024

Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=ji…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-compiletestArea: The compiletest test runnerA-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.WG-debuggingWorking group: Bad Rust debugging experiences

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

    Participants

    @saethlin@jieyouxu@rustbot

    Issue actions

      Delete all code for handling lldb and gdb versions that don't support Rust natively · Issue #128953 · rust-lang/rust