Closed
Description
We have a fair bit of code in both src/tools/compiletest
and tests/debuginfo
devoted to handling the 7.X releases of gdb, because those had no built-in Rust support. But as of this year at least, the oldest supported RHEL version is now shipping gdb 8.2 so there's no reason for us to be pretending to support versions of gdb before 8.2.
The dev guide also vaguely indicates that this distinction for lldb shouldn't exist anymore:
https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L216
https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L253-L255
- Delete all the
gdbg
annotations intests/debuginfo
, and convert allgdbr
to justgdb
Delete all thelldbg
annotations intests/debuginfo
and convert alllldbr
tolldb
Check if the tests still pass (you've got a 50/50 shot on this, debuginfo tests are cursed)Delete the code in compiletest that handles this "Rust support" version gap for gdb, and for lldb
Activity
Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=<try>
Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=<try>
Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=<try>
saethlin commentedon Aug 18, 2024
Turns out the modern side of the version split for lldb is the version without Rust support. That's a bummer, but still the goal here is to delete unused code.
Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=ji…
Auto merge of #129218 - saethlin:gdb-supports-rust-now, r=jieyouxu