Add a dont-check-error-annotations to compiletest
#132647
Labels
A-compiletest
Area: The compiletest test runner
C-feature-request
Category: A feature request, i.e: not implemented / a PR.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
BoxyUwU
added
A-compiletest
rustbot
added
the
needs-triage
BoxyUwU
added
T-bootstrap
|
Somewhat related is also #46667. |
This was referenced Apr 6, 2025
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Apr 10, 2025
Rollup merge of rust-lang#139489 - petrochenkov:noreqann, r=jieyouxu compiletest: Add directive `dont-require-annotations` for making matching on specific diagnostic kinds non-exhaustive. E.g. `//@ dont-require-annotations:ERROR`, like in the examples in this PR. cc rust-lang#139427 (comment) Closes rust-lang#132647 FYI `@BoxyUwU` since you've wanted this. r? `@jieyouxu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cc @jieyouxu
It would be nice if compiletest could support a
//@ dont-check-error-annotationsannotation that would not require you to annotate your file with//~^ ERROR:anywhere. This would be useful for cases where I only care that the test doesn't start ICEing. Ideally we'd never need this but sometimes I wind up with hundreds of errors with useless spans and it's just not realistic (or helpful) to annotate it all. See for example this test, all the error annotations are in the wrong place as macro diagnostics emit the error on the macro definition not the caller. This means that we'd wind up with ~100 error annotations on the insides of the macros which is not a helpful assertion whatsoever.The text was updated successfully, but these errors were encountered: