Skip to content

issue-93775 test overflows stack with debug assertions enabled #133432

Closed
@beepster4096

Description

@beepster4096
Contributor

When debug-assertions=true is in config.toml, the test tests\ui\associated-consts\issue-93775.rs fails with a stack overflow. I think it stems from here in rustc_const_eval::const_eval::eval_queries::eval_to_allocation_raw_provider:

    if cfg!(debug_assertions) {
        // Make sure we format the instance even if we do not print it.
        // This serves as a regression test against an ICE on printing.
        // The next two lines concatenated contain some discussion:
        // https://rust-lang.zulipchat.com/#narrow/stream/146212-t-compiler.2Fconst-eval/
        // subject/anon_const_instance_printing/near/135980032
        let instance = with_no_trimmed_paths!(key.value.instance.to_string());
        trace!("const eval: {:?} ({})", key, instance);
    }

I tested this on x86_64-pc-windows-msvc, unsure if it happens on other platforms.

Activity

added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Nov 25, 2024
jieyouxu

jieyouxu commented on Nov 25, 2024

@jieyouxu
Member
added
A-testsuiteArea: The testsuite used to check the correctness of rustc
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
I-flaky-testIssue: A test is flaky/unreliable/spuriously fails
and removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
I-flaky-testIssue: A test is flaky/unreliable/spuriously fails
on Nov 25, 2024
beepster4096

beepster4096 commented on Nov 25, 2024

@beepster4096
ContributorAuthor

I added my platform to the issue. It might be relevant because that other issue was also on windows.

ChrisDenton

ChrisDenton commented on Nov 26, 2024

@ChrisDenton
Member

What stack size do we use on Windows?

added a commit that references this issue on Dec 16, 2024

Rollup merge of rust-lang#134372 - jieyouxu:disable-flaky-test, r=Nor…

0a77972

7 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.O-windows-msvcToolchain: MSVC, Operating system: WindowsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @ChrisDenton@beepster4096@jieyouxu@rustbot

      Issue actions

        issue-93775 test overflows stack with debug assertions enabled · Issue #133432 · rust-lang/rust