You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
change any docs that say struct layout is defined by default,
ensure we have support for repr(c) attribute on structs
To pick up a draggable item, press the space bar.
While dragging, use the arrow keys to move the item.
Press space again to drop the item in its new position, or press escape to cancel.
Taking this. I'll add a lint for using non-#[repr(C)] structs in FFI, transitively, as well as adding a separate codepath through trans that makes sure such structs have a C-compatible ABI.
Due to the dead_code lint now changing behavior in the presence of #[repr(C)], I'd really like to see the FFI lint done sooner rather than later, even if nothing else is done yet.
In progress patch: https://github.com/cmr/rust/tree/struct-undef-repr
Basically done, not sure if bug in my code or in the libunwind bindings but #12201 is needed to make errors caused by this not eye-bleeding-awful to debug.
Activity
[-]Tracking buf for RFC 18 - undefined struct layout[/-][+]Tracking bug for RFC 18 - undefined struct layout[/+]pcwalton commentedon May 22, 2014
What exactly is the action needed here? Add the lint, or something else?
pnkfelix commentedon May 22, 2014
Action items:
repr(c)attribute on structspnkfelix commentedon May 22, 2014
P-backcompat-lang, 1.0.
emberian commentedon May 22, 2014
Taking this. I'll add a lint for using non-
#[repr(C)]structs in FFI, transitively, as well as adding a separate codepath through trans that makes sure such structs have a C-compatible ABI.lilyball commentedon Jun 23, 2014
Due to the
dead_codelint now changing behavior in the presence of#[repr(C)], I'd really like to see the FFI lint done sooner rather than later, even if nothing else is done yet.emberian commentedon Jul 24, 2014
In progress patch: https://github.com/cmr/rust/tree/struct-undef-repr
Basically done, not sure if bug in my code or in the libunwind bindings but #12201 is needed to make errors caused by this not eye-bleeding-awful to debug.
librustc: handle repr on structs, require it for ffi, unify with packed
Rollup merge of rust-lang#81387 - c410-f3r:tests-tests-tests, r=petro…
Rollup merge of rust-lang#81387 - c410-f3r:tests-tests-tests, r=petro…