Skip to content

check-pretty fails with RUSTFLAGS="-Z time-passes" #14607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kmcallister opened this issue Jun 2, 2014 · 2 comments
Closed

check-pretty fails with RUSTFLAGS="-Z time-passes" #14607

kmcallister opened this issue Jun 2, 2014 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@kmcallister
Copy link
Contributor 

        task '[pretty] run-pass/variant-structs-trivial.rs' failed at 'explicit failure', /home/keegan/proj/rust/rust2/src/compiletest/runtest.rs:1305

---- [pretty] run-pass/vec-concat.rs stdout ----

        error: pretty-printing failed in round 1
        status: exit code: 101
        command: x86_64-unknown-linux-gnu/stage1/bin/rustc - --pretty normal --target=x86_64-unknown-linux-gnu -L x86_64-unknown-linux-gnu/test/run-pass/vec-concat.stage1-x86_64-unknown-linux-gnu.libaux -Z time-passes --cfg debug -O -L x86_64-unknown-linux-gnu/rt
        stdout:
        ------------------------------------------

        ------------------------------------------
        stderr:
        ------------------------------------------
        <anon>:1:1: 1:5 error: expected item but found `time`
        <anon>:1 time: 0.002 s  parsing
                 ^~~~

        ------------------------------------------
@kmcallister kmcallister added the A-testsuite Area: The testsuite used to check the correctness of rustc label Sep 27, 2014
@steveklabnik
Copy link
Member

Traige: this still happens.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Oct 29, 2016
Closed
@Mark-Simulacrum
Copy link
Member

Today, I see that RUSTFLAGS="-Ztime-passes" ./x.py test -i --stage 1 src/test/pretty passed locally. So I suspect that this is fixed, therefore I'm closing.

bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14610 - lowr:fix/hygiene-for-meta-item, r=Vey…
34ebb30 
…kril

fix: Resolve `$crate` in derive paths

Paths in derive meta item list may contain any kind of paths, including those that start with `$crate` generated by macros. We need to take hygiene into account when we lower paths in the list.

This issue was identified while investigating rust-lang#14607, though this patch doesn't fix the broken trait resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @pnkfelix @kmcallister @Mark-Simulacrum