-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Open
Labels
A-CIArea: Our Github Actions CIArea: Our Github Actions CIA-codegenArea: Code generationArea: Code generationA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-discussionCategory: Discussion or questions that doesn't represent real issues.Category: Discussion or questions that doesn't represent real issues.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Description
New codegen or assembly tests have a very high chance of passing PR CI and then failing full checks. There are lots of reasons for that, but one of them is 64-bit vs 32-bit differences.
I wonder whether it would make sense to run these tests against i686-unknown-linux-gnu on PR CI, the same way we do for mir-opt tests. I'd expect codegen tests to run pretty quickly.
RalfJung
Metadata
Metadata
Assignees
Labels
A-CIArea: Our Github Actions CIArea: Our Github Actions CIA-codegenArea: Code generationArea: Code generationA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-discussionCategory: Discussion or questions that doesn't represent real issues.Category: Discussion or questions that doesn't represent real issues.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.