Skip to content

Incomplete tests for non-android arm & mips. #14848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luqmana opened this issue Jun 12, 2014 · 3 comments
Closed

Incomplete tests for non-android arm & mips. #14848

luqmana opened this issue Jun 12, 2014 · 3 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-MIPS Target: MIPS processors

Comments

@luqmana
Copy link
Member

luqmana commented Jun 12, 2014

run-pass/intrinsic-alignment.rs and run-pass/rec-align-u64.rs don't run on non-android arm/mips since we haven't filled in a cfg for it. So they just fail with 'no main function'.

Pretty easy to fix: determine the right values for alignment/size and fill in the values.
@steveklabnik
Copy link
Member

Triage: it looks like arm may have been added, but not mips.

@AnthonyBroadCrawford
Copy link

@steveklabnik may I please take this?

@brson
Copy link
Contributor

brson commented Jun 27, 2016

Looks fixed to me. Both tests now cover all hardware architectures with one path for x86 and one for every other.

@brson brson closed this as completed Jun 27, 2016
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14848 - bm-w:fix/highlight-let-else-return, r…
e8ae2d3 
…=Veykril

Fix `preorder_expr` skipping the `else` block of let-else statements

Fixes exit/yield points not getting highlighted in such blocks for `highlight_related` (rust-lang#14813; and possibly other bugs in features that use `preorder_expr`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-MIPS Target: MIPS processors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@AnthonyBroadCrawford @steveklabnik @brson @luqmana @thestinger