Skip to content

Confusing cmd syntax errors with -C codegen-units #17587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kmcallister opened this issue Sep 27, 2014 · 0 comments · Fixed by #18979
Closed

Confusing cmd syntax errors with -C codegen-units #17587

kmcallister opened this issue Sep 27, 2014 · 0 comments · Fixed by #18979
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-driver Area: rustc_driver that ties everything together into the `rustc` compiler E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@kmcallister
Copy link
Contributor 

$ rustc -C codegen-units=foo
error: codegen option `codegen-units` takes no value
$ rustc -C codegen-units
error: codegen option `codegen-units` requires a value (-C codegen-units=<value>)
@kmcallister kmcallister added A-driver Area: rustc_driver that ties everything together into the `rustc` compiler E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Sep 27, 2014
@huonw huonw added the A-diagnostics Area: Messages for errors, warnings, and lints label Sep 27, 2014
@inrustwetrust inrustwetrust mentioned this issue Nov 15, 2014
Merged
lnicola pushed a commit to lnicola/rust that referenced this issue Jul 28, 2024
@bors
Auto merge of rust-lang#17587 - joshka:jm/edit-name-after-refactor, r…
82d0187 
…=Veykril

Trigger VSCode to rename after extract variable assist is applied

When the user applies the "Extract Variable" assist, the cursor is
positioned at the newly inserted variable. This commit adds a command
to the assist that triggers the rename action in VSCode. This way, the
user can quickly rename the variable after applying the assist.

Fixes part of: rust-lang#17579

https://github.com/user-attachments/assets/4cf38740-ab22-4b94-b0f1-eddd51c26c29

I haven't yet looked at the module or function extraction assists yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-driver Area: rustc_driver that ties everything together into the `rustc` compiler E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Slightly improved rustc error messages for invalid -C arguments inrustwetrust/rust
2 participants
@kmcallister @huonw