-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.Call for participation: An issue has been fixed and does not reproduce, but no test has been added.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
#20728 gives the absolute minimum information about shadowed type parameters, just telling you there is one, and which it is. The span is the whole method and so is suboptimal (would be better to point to the specific problematic type parameter), and it would be nice to indicate the shadowed type parameter, similar to the shadowed lifetime warning.
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.Call for participation: An issue has been fixed and does not reproduce, but no test has been added.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
steveklabnik commentedon Jan 4, 2016
Traige:
src/test/compile-fail/shadowed-type-parameter.rs
can be used to reproduce, and the span still shows the whole name.estebank commentedon Apr 20, 2017
Current output:
Mark-Simulacrum commentedon Jun 21, 2017
I believe the current output (same as in previous comment) fixes this. Marking as E-needstest, a UI test (moving src/test/compile-fail/shadowed-type-parameter.rs) would be great. I believe this is an easy task, so marking as such -- I can provide mentoring instructions as needed, let me know.
ui
#42953Rollup merge of rust-lang#42953 - estebank:fix-20729, r=petrochenkov