-
Notifications
You must be signed in to change notification settings - Fork 13.3k
JSON serialization of HashMaps with Enum keys is broken #21470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
japaric opened this issue
Jan 21, 2015
· 3 comments
· Fixed by rust-lang-deprecated/rustc-serialize#32 or #21662
Closed
JSON serialization of HashMaps with Enum keys is broken #21470
japaric opened this issue
Jan 21, 2015
· 3 comments
· Fixed by rust-lang-deprecated/rustc-serialize#32 or #21662
Comments
cc @oli-obk |
I think it is that json::encode ignores encoder errors and the error case is new -- not a valid map key. |
Related PR #19490 Since encoding errors there now, the obvious bug would be that the error is suppressed silently. |
This was referenced Jan 22, 2015
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this issue
Jan 26, 2015
closes rust-lang#21470 on main rust repository was fixed on rust-lang/rustc-serialize (see rust-lang-deprecated/rustc-serialize#32)
barosl
added a commit
to barosl/rust
that referenced
this issue
Jan 27, 2015
…ichton closes rust-lang#21470 on main rust repository was fixed on rust-lang/rustc-serialize (see rust-lang-deprecated/rustc-serialize#32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
STR
Output
Version
The second hashmap was properly being serialized as
{"Foo":0}
with a two days old nightly (rustc 1.0.0-nightly (dcaeb6aa2 2015-01-18 11:28:53 +0000)
).cc @aturon @alexcrichton @gankro
The text was updated successfully, but these errors were encountered: