The "testing" section of the rust book needs a small correction #24030
Comments
|
nice catch! |
|
Should this instance be Judging from crates.io, it looks like Incoming PR to that effect. |
Oh, really now? |
|
I actually vote for everything else to be |
|
Aw, shoot. From some more grepping, the style guide and the language reference both refer to |
|
Ok but... to me it doesn't make sense that we use |
|
/me considers giving Steve a choose-your-own-adventure pair of pull requests. |
callahad
added a commit
to callahad/rust
that referenced
this issue
Apr 4, 2015
Fixes rust-lang#24030 Of the four code samples with modules in TRPL: - 2 use `mod test` - 2 use `mod tests` We should be consistent here, but which is right? The stdlib is split: $ grep -r 'mod tests {' src/lib* | wc -l 63 $ grep -r 'mod test {' src/lib* | wc -l 58 Subjectively, I like the plural. Maybe you, dear reviewer, do too?
callahad
added a commit
to callahad/rust
that referenced
this issue
Apr 4, 2015
Fixes rust-lang#24030 Of the four code samples with modules in TRPL: - 2 use `mod test` - 2 use `mod tests` We should be consistent here, but which is right? The stdlib is split: $ grep -r 'mod tests {' src/lib* | wc -l 63 $ grep -r 'mod test {' src/lib* | wc -l 58 Subjectively, I like the plural, but both the language reference and the style guide recommend the singular. So we'll go with that here, for now.
This was referenced Apr 4, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Apr 7, 2015
Fixes rust-lang#24030 Of the four code samples with modules in TRPL: - 2 use `mod test` - 2 use `mod tests` We should be consistent here, but which is right? The stdlib is split: $ grep -r 'mod tests {' src/lib* | wc -l 63 $ grep -r 'mod test {' src/lib* | wc -l 58 Subjectively, I like the plural, but both the language reference and the style guide recommend the singular. So we'll go with that here, for now. r? @steveklabnik
bors
added a commit
that referenced
this issue
Apr 25, 2015
Changes the style guidelines regarding unit tests to recommend using a sub-module named "tests" instead of "test" for unit tests as "test" might clash with imports of libtest (see #23870, #24030 and http://users.rust-lang.org/t/guidelines-naming-of-unit-test-module/1078 for previous discussions). r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code example at https://doc.rust-lang.org/book/testing.html#documentation-tests should be corrected changing
mod tests {intomod test {.The text was updated successfully, but these errors were encountered: