Skip to content

On docs pages, pressing '/' should not show Help #24289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jruderman opened this issue Apr 10, 2015 · 1 comment · Fixed by #24337
Closed

On docs pages, pressing '/' should not show Help #24289

jruderman opened this issue Apr 10, 2015 · 1 comment · Fixed by #24337
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jruderman
Copy link
Contributor

On http://static.rust-lang.org/doc/master/std/ in Firefox, pressing the / key both initiates an in-page search and opens a help overlay. Only pressing ? should open the help overlay.
@steveklabnik
Copy link
Member

I can confirm this here as well.

@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 10, 2015
barosl added a commit to barosl/rust that referenced this issue Apr 11, 2015
@barosl
rustdoc: Prevent '/' from showing the help dialog
0caca8f 
Only '?' should do that.

Fixes rust-lang#24289.
@barosl barosl mentioned this issue Apr 11, 2015
Merged
barosl added a commit to barosl/rust that referenced this issue Apr 13, 2015
@barosl
rustdoc: Prevent '/' from showing the help dialog
cef96b9 
Only '?' should do that.

Fixes rust-lang#24289.
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 14, 2015
@alexcrichton
rollup merge of rust-lang#24337: barosl/rustdoc-help-key
5780fc1 
Only '?' should do that.

Fixes rust-lang#24289.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Prevent '/' from showing the help dialog barosl/rust
2 participants
@steveklabnik @jruderman