Skip to content

rustdoc generates duplicate id attributes #25001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apasel422 opened this issue Apr 30, 2015 · 1 comment · Fixed by #30036
Closed

rustdoc generates duplicate id attributes #25001

apasel422 opened this issue Apr 30, 2015 · 1 comment · Fixed by #30036
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@apasel422
Copy link
Contributor

When two items in the same documentation page have the same name, rustdoc generates duplicate HTML id attributes for them. This makes the HTML invalid, but more importantly, it makes it impossible to link to anything but the one that shows up first in the source.

For example, Vec's page contains multiple impls of IntoIterator, and therefore multiple HTML elements that have an id attribute of assoc_type.Item, assoc_type.IntoIter, and method.into_iter.

This is not limited to impls of the same trait, as different traits (and inherent impls) could define methods or associated types with the same name.
@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 30, 2015
@nagisa
Copy link
Member

nagisa commented May 3, 2015

Similar to #17476 #20700

cc @alexcrichton as you’ve fixed #17476 and closed #20700 as dupe of #17476

@huonw huonw mentioned this issue May 22, 2015
Closed
@apasel422 apasel422 mentioned this issue Sep 18, 2015
Closed
@apasel422 apasel422 mentioned this issue Oct 30, 2015
Closed
@apasel422 apasel422 mentioned this issue Nov 24, 2015
Merged
bors added a commit that referenced this issue Dec 8, 2015
@bors
Auto merge of #30036 - mitaa:doc_id, r=alexcrichton
461c460 
This expands the code which generates unique IDs for Markdown headers within a single block to each rendered page.

fixes #25001
fixes #29449
@shalzz shalzz mentioned this issue Dec 24, 2018
Closed
@kentfredric kentfredric mentioned this issue Apr 30, 2019
Closed
@fmease fmease mentioned this issue Feb 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rustdoc: generate unique ID attributes for each page mitaa/rust
3 participants
@steveklabnik @nagisa @apasel422