Skip to content

Convert rust_run_program.cpp to Rust #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
graydon opened this issue Jun 21, 2012 · 6 comments · Fixed by #9280
Closed

Convert rust_run_program.cpp to Rust #2674

graydon opened this issue Jun 21, 2012 · 6 comments · Fixed by #9280
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

At this point it's really plausible to put almost all this logic in rust, with the exception of the extern global access.
@Dretch Dretch mentioned this issue Apr 28, 2013
Closed
@emberian
Copy link
Member

emberian commented Jul 7, 2013

@graydon I can't find rust_run_program anywhere in the tree, I assume this is obsolete?

@Dretch
Copy link
Contributor

Dretch commented Jul 7, 2013

@cmr rust_run_program.cpp still exists and I believe at least some of it could be converted to rust (environ access). So I think this bug is not quite obsolete.

@emberian
Copy link
Member

emberian commented Jul 7, 2013

Oh, it's a filename! Righty. Editing the issue, as there is no longer a chdir there.

@emberian
Copy link
Member

emberian commented Jul 7, 2013

Also a note: the extern global should be implementable in Rust via static mut, I believe.

@graydon
Copy link
Contributor Author

graydon commented Jul 11, 2013

accepted for production-ready milestone

@thestinger
Copy link
Contributor

Sadly, this is still around.

@alexcrichton alexcrichton mentioned this issue Sep 18, 2013
Merged
bors added a commit that referenced this issue Sep 19, 2013
@bors
auto merge of #9280 : alexcrichton/rust/less-c++, r=brson
3c00131 
Some of the functions could be converted to rust, but the functions dealing with
signals were moved to rust_builtin.cpp instead (no reason to keep the original
file around for one function).

Closes #2674

Because less C++ is better C++!
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@tautschnig @zhassan-aws
Free up additional disk space on GitHub runner (rust-lang#2674)
2391295 
Co-authored-by: Zyad Hassan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove rust_run_program.cpp alexcrichton/rust
4 participants
@graydon @emberian @Dretch @thestinger