Skip to content

Tracking issue for file_try_clone #31405

@sfackler

Description

@sfackler
Member
No description provided.

Activity

added
T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.
B-unstableBlocker: Implemented in the nightly compiler and unstable.
on Feb 4, 2016
bluss

bluss commented on Mar 1, 2016

@bluss
Contributor

I think this was intended to be picked up by Rust 1.8 stabilization? @alexcrichton, do you know? There was a wish to stabilize it soon when it was added.

alexcrichton

alexcrichton commented on Mar 1, 2016

@alexcrichton
Member

I don't think so, no. I think at the last minute we thought the impl was "weird" so decided to introduce as unstable? Should be an easy FCP next cycle though.

alexcrichton

alexcrichton commented on Mar 11, 2016

@alexcrichton
Member

🔔 This issue is now entering its cycle-long final comment period for stabilization in 1.9 🔔

added
final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
and removed on Mar 11, 2016
aturon

aturon commented on Apr 6, 2016

@aturon
Contributor

For the record, the naming here is in part justified by the already-stable method on tcp streams.

SimonSapin

SimonSapin commented on Apr 7, 2016

@SimonSapin
Contributor

The naming convention of try_FOO for methods that return Result is also consistent with rust-lang/rfcs#1542 (try_from and try_into).

The try! macro however takes a Result and does not generally return one. So we may end up with try!(x.try_clone()) and try!(y.try_into()) (which sounds repetitive and has two different meaning for the same word) being used a lot… But then if the ? operator sticks around maybe try! will be deprecated or go out of fashion, leaving us with x.try_clone()? and y.try_into()? which looks nicer to me.

alexcrichton

alexcrichton commented on Apr 7, 2016

@alexcrichton
Member

The libs team discussed this during triage yesterday and the decision was to stabilize

added a commit that references this issue on Apr 11, 2016
552eda7
added a commit that references this issue on Apr 12, 2016
bed32d8
added a commit that references this issue on Apr 12, 2016
1f8f3d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-unstableBlocker: Implemented in the nightly compiler and unstable.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @alexcrichton@SimonSapin@aturon@sfackler@bluss

        Issue actions

          Tracking issue for file_try_clone · Issue #31405 · rust-lang/rust