-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Closed
Labels
B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.
Metadata
Metadata
Assignees
Labels
B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
bluss commentedon Mar 1, 2016
I think this was intended to be picked up by Rust 1.8 stabilization? @alexcrichton, do you know? There was a wish to stabilize it soon when it was added.
alexcrichton commentedon Mar 1, 2016
I don't think so, no. I think at the last minute we thought the impl was "weird" so decided to introduce as unstable? Should be an easy FCP next cycle though.
alexcrichton commentedon Mar 11, 2016
🔔 This issue is now entering its cycle-long final comment period for stabilization in 1.9 🔔
aturon commentedon Apr 6, 2016
For the record, the naming here is in part justified by the already-stable method on tcp streams.
SimonSapin commentedon Apr 7, 2016
The naming convention of
try_FOO
for methods that returnResult
is also consistent with rust-lang/rfcs#1542 (try_from
andtry_into
).The
try!
macro however takes aResult
and does not generally return one. So we may end up withtry!(x.try_clone())
andtry!(y.try_into())
(which sounds repetitive and has two different meaning for the same word) being used a lot… But then if the?
operator sticks around maybetry!
will be deprecated or go out of fashion, leaving us withx.try_clone()?
andy.try_into()?
which looks nicer to me.alexcrichton commentedon Apr 7, 2016
The libs team discussed this during triage yesterday and the decision was to stabilize
std: Stabilize APIs for the 1.9 release
Auto merge of #32804 - alexcrichton:stabilize-1.9, r=brson
std: Stabilize APIs for the 1.9 release