Skip to content

Wording in Concurrency section #36939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrian5 opened this issue Oct 3, 2016 · 1 comment
Closed

Wording in Concurrency section #36939

adrian5 opened this issue Oct 3, 2016 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@adrian5
Copy link
Contributor

adrian5 commented Oct 3, 2016

https://github.com/rust-lang/rust/blob/master/src/doc/book/concurrency.md

Rust's memory safety features also apply to its concurrency story too.

Also/too; I think the trailing too can just be gotten rid of.

It allows the sharing of data between threads, but shared mutable data is unsafe and when threads are involved can cause data races!

Above sentence should use additional punctuation to make it more readable, e.g.:

It allows the sharing of data between threads, but shared mutable data is unsafe and – when threads are involved – can cause data races!
@steveklabnik
Copy link
Member

I would happily take a PR for this!

@steveklabnik steveklabnik added A-docs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Oct 3, 2016
@nikhilshagri nikhilshagri mentioned this issue Oct 4, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this issue Oct 6, 2016
Rollup merge of rust-lang#36957 - cynicaldevil:docs, r=frewsxcv
534a2b5 
Minor modifications in concurrency section of the Rust book

Fixes rust-lang#36939
r? @steveklabnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @adrian5