Skip to content

does the note for E0369 need to repeat the entire span? #39650

Closed
@durka

Description

@durka
Contributor

I got this error (I missed a ?):

error[E0369]: binary operation `!=` cannot be applied to type `std::result::Result<flow::EventContour, flow::Error>`
   --> crates/front/cli/src/lib.rs:245:23
    |
245 |                 while found.run(ParkState::None, &self.tx, CLIComms) != flow::EventContour::Finishing {}
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: an implementation of `std::cmp::PartialEq` might be missing for `std::result::Result<flow::EventContour, flow::Error>`
   --> crates/front/cli/src/lib.rs:245:23
    |
245 |                 while found.run(ParkState::None, &self.tx, CLIComms) != flow::EventContour::Finishing {}
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

There's no information gained by printing the span again. Maybe there is some situation where it isn't the same?

Activity

changed the title [-]does the note for E0369 need to repeat the entire span[/-] [+]does the note for E0369 need to repeat the entire span?[/+] on Feb 8, 2017
durka

durka commented on Feb 8, 2017

@durka
ContributorAuthor

It seems to be always the same span (namely lhs_expr.span).

added a commit that references this issue on Feb 10, 2017

Rollup merge of rust-lang#39707 - durka:parsimonious-span-note, r=jon…

84ad515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @durka

        Issue actions

          does the note for E0369 need to repeat the entire span? · Issue #39650 · rust-lang/rust