Skip to content

Tracking issue for RFC 1857: Stabilize drop order #43034

@aturon

Description

@aturon
Member

RFC

For this RFC, what's needed is documentation. There's no behavioral change or feature-flag stabilization.

Activity

added
B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.
T-langRelevant to the language team
on Jul 3, 2017
aochagavia

aochagavia commented on Jul 4, 2017

@aochagavia
Contributor

Besides documentation, I think a couple of tests would be useful as well to prevent accidentally changing the order.

aochagavia

aochagavia commented on Jul 8, 2017

@aochagavia
Contributor

@aturon In the RFC I mentioned updating the book, but upon second thought relying on a particular drop order seems to be a niche use case. Therefore it seems reasonable to me to omit it in the book and only mention it in the reference. Do you agree with that?

vitalyd

vitalyd commented on Jul 8, 2017

@vitalyd

The book should mention that the drop order is specified, but can refer the reader to the reference for elaboration.

aochagavia

aochagavia commented on Jul 9, 2017

@aochagavia
Contributor

@steveklabnik @carols10cents I am trying to find a good place in the book to put tell that drop order is specified. I guess if we were to do this it would go in the chapter about drop. Unfortunately, the example uses a struct with only one field, so we cannot use the example to talk about drop order. Maybe we could add an extra field and then explain which field is dropped first? Then, we could link to the reference for more information.

I am still not sure about mentioning drop order in the book, so I am also interested in your opinion regarding that.

steveklabnik

steveklabnik commented on Jul 10, 2017

@steveklabnik
Member

Yes, we should mention it; we already do in the lifetimes section, I believe. The drop chapter is the right place though, and another example is a good idea.

arielb1

arielb1 commented on Jul 11, 2017

@arielb1
Contributor

The "panic during initialization drops elements in reverse order" is actually a part of the "temporary lifetimes" rules, which are described in https://github.com/nikomatsakis/rust-memory-model/issues/17. Do we want to document them?

added a commit that references this issue on Jul 13, 2017
added
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
on Jul 27, 2017
Centril

Centril commented on Sep 15, 2018

@Centril
Contributor

I believe there's nothing left to do here, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-langRelevant to the language team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @steveklabnik@vitalyd@aturon@Centril@arielb1

        Issue actions

          Tracking issue for RFC 1857: Stabilize drop order · Issue #43034 · rust-lang/rust