Skip to content

Some trait implementations are documented twice #45584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GuillaumeGomez opened this issue Oct 27, 2017 · 1 comment
Closed

Some trait implementations are documented twice #45584

GuillaumeGomez opened this issue Oct 27, 2017 · 1 comment
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

An example can be found in [HashSet](https://doc.rust-lang.org/nightly/std/collections/struct.HashSet.html#impl-BitAnd<&'b HashSet<T, S>>) docs.
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-dev-tools-rustdoc A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Oct 27, 2017
@ollie27 ollie27 mentioned this issue Oct 29, 2017
Merged
@ollie27
Copy link
Member

ollie27 commented Oct 29, 2017

This was caused by #44969. #45620 fixes it.

@TimNN TimNN added the C-bug Category: This is a bug. label Oct 31, 2017
@steveklabnik steveklabnik removed the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Oct 31, 2017
kennytm added a commit to kennytm/rust that referenced this issue Nov 7, 2017
@kennytm
Rollup merge of rust-lang#45620 - ollie27:rustdoc_impl_generic_dupe, …
e957d52 
…r=QuietMisdreavus

rustdoc: Fix duplicated impls with generics

The same type can appear multiple times in impls so we need to use a set
to avoid adding it multiple times.

Fixes: rust-lang#45584
bors added a commit that referenced this issue Nov 7, 2017
@bors
Auto merge of #45620 - ollie27:rustdoc_impl_generic_dupe, r=QuietMisd…
3e7f501 
…reavus

rustdoc: Fix duplicated impls with generics

The same type can appear multiple times in impls so we need to use a set
to avoid adding it multiple times.

Fixes: #45584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @TimNN @GuillaumeGomez @ollie27