Skip to content

Provide a way to get feedback on compiler error rates #45857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
estebank opened this issue Nov 8, 2017 · 7 comments
Open

Provide a way to get feedback on compiler error rates #45857

estebank opened this issue Nov 8, 2017 · 7 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. metabug Issues about issues themselves ("bugs about bugs") T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

estebank commented Nov 8, 2017

As per #45452 (comment), and other conversations that have been had over time, there's a feeling that we should have ways of identifying what rustc features are being used/encountered. This can range from full featured telemetry support in rustc/cargo, to a simple webapp accepting people to post compiler output. Right now the only ways we receive feedback for confusing output are:

  • IRC/gitter
  • this issue tracker
  • stackoverflow
  • /r/rust

If we added telemetry support on rustc, it would also have to be opt-in, and it could start with being a simple flag passed to rustc to send a post request with the text output of the compiler. These reports could then be aggregated by type.

@estebank estebank added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. metabug Issues about issues themselves ("bugs about bugs") labels Nov 8, 2017
@kennytm
Copy link
Member

kennytm commented Nov 8, 2017

I think we better keep rustc untouched, and telemetry (the post request sender) is better belong on cargo:

  • the "flag" can be part of ~/.cargo/config so you don't need to opt-in everytime
  • the "flag" can be configured when you install rustup the first time
  • rustc remains free of any network code
  • cargo already needs to connect to the internet (outside of airplane mode)

@nikomatsakis
Copy link
Contributor

@kennytm those sound like solid arguments to me

@bluss
Copy link
Member

bluss commented Nov 10, 2017

Rustup already has a config flag for telemetry. rust-lang/rustup#341

@kennytm
Copy link
Member

kennytm commented Nov 10, 2017

Oh in this case the entire thing can be implemented on top of rustup's rustc/cargo wrapper already?

@estebank
Copy link
Contributor Author

@steveklabnik
Copy link
Member

I don't believe that we've done anything in this area in the past few years.

@crlf0710 crlf0710 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 11, 2020
@estebank
Copy link
Contributor Author

estebank commented Aug 3, 2023

I've formalized some of my thoughts on the matter: https://estebank.github.io/rustc-metrics.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. metabug Issues about issues themselves ("bugs about bugs") T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants