-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Closed
Labels
C-feature-acceptedCategory: A feature request that has been accepted pending implementation.Category: A feature request that has been accepted pending implementation.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-feature-acceptedCategory: A feature request that has been accepted pending implementation.Category: A feature request that has been accepted pending implementation.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
bstrie commentedon Dec 5, 2017
I thought that all types in libstd were there for a reason, is there a historical reason that this was left in? Should we audit libstd for other types that don't need to be there?
clarfonthey commentedon Dec 5, 2017
@bstrie everything in
libcore
is also inlibstd
, more or less.libcore
is just a smaller version oflibstd
that doesn't rely on platform-specific behaviour at all.I do think that
libstd
should be audited for types that can be moved tolibcore
; this is just one case of that.sfackler commentedon Dec 5, 2017
AFAIK it's only in std because the rest of the time module was defined there, and
Instant
andSystemTime
both need std. Seems fine to move Duration though.Mark-Simulacrum commentedon Dec 6, 2017
I think a PR for this would be reasonable. Marking as feature-accepted.
Auto merge of #46666 - clarcharr:duration_core, r=alexcrichton