-
Notifications
You must be signed in to change notification settings - Fork 13.3k
permit imports in fn, iter, obj scope #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Comments
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this issue
Dec 12, 2017
Closes rust-lang#49
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this issue
Dec 12, 2017
Closes rust-lang#49
kazcw
pushed a commit
to kazcw/rust
that referenced
this issue
Oct 23, 2018
Tests are still up in the air because of rust-lang#49.
kazcw
pushed a commit
to kazcw/rust
that referenced
this issue
Oct 23, 2018
Some intrinsics need to be invoked with constant arguments to get the right instruction to get generated, so this commit enhances the `assert_instr` macro to enable this ability. Namely you pass constant arguments like: #[assert_instr(foo, a = b)] where this will assert that the intrinsic, when invoked with argument `a` equal to the value `b` and all other arguments passed from the outside, will generate the instruction `foo`. Closes rust-lang#49
dlrobertson
pushed a commit
to dlrobertson/rust
that referenced
this issue
Nov 29, 2018
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this issue
Oct 1, 2021
Feature/const generics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Currently we only permit import in mod scopes. It probably makes sense to
permit this in fn, iter and obj scopes as well, it's harmless there and potentially
restricts visibility of the import. Might as well.
The text was updated successfully, but these errors were encountered: