Skip to content

stable backport PR 52232 #52312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pnkfelix opened this issue Jul 12, 2018 · 7 comments
Closed

stable backport PR 52232 #52312

pnkfelix opened this issue Jul 12, 2018 · 7 comments
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-core Relevant to the core team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

This is a dummy issue linking to PR #52232 so that we can have an open issue (which is apparently a requirement if one wants to leverage the rfcbot).

@pnkfelix pnkfelix added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 12, 2018
@pnkfelix
Copy link
Member Author

@rfcbot fcp merge

I propose that we approve backporting #52232 to stable.

I'm more wary of stable backports than I am of beta backports, so: I am not inverting the rfcbot on this ticket the same way that I did on #52311. If we do not get a sufficient number of check boxes ticked off, then the PR will not be approved for a backport to the stable channel.

@rfcbot
Copy link
Collaborator

rfcbot commented Jul 12, 2018

Team member @pnkfelix has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 12, 2018
@nagisa
Copy link
Member

nagisa commented Jul 12, 2018

@rfcbot reviewed

I find it kind of objectionable that we’ll end up releasing not one but two point releases this cycle…

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 12, 2018
@kennytm kennytm added the T-core Relevant to the core team, which will review and decide on the PR/issue. label Jul 12, 2018
@pietroalbini
Copy link
Member

By the way, isn't the core team responsible for approving point releases?

@Mark-Simulacrum Mark-Simulacrum added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Jul 12, 2018
@Mark-Simulacrum
Copy link
Member

The core team also discussed this today and we're generally in favor of a 1.27.2 release, scheduled for next Thursday. I will be creating and cross-linking an internals post to this thread after the next nightly release asking for interested users to test and try to find holes in the fix (and, probably, match ergonomics in general) with the goal of finding problems before the point release.

@pnkfelix pnkfelix added P-high High priority I-nominated labels Jul 13, 2018
@rfcbot
Copy link
Collaborator

rfcbot commented Jul 14, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 14, 2018
@pietroalbini pietroalbini removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jul 14, 2018
@pnkfelix
Copy link
Member Author

closing, @Mark-Simulacrum says this has been backported.

@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-core Relevant to the core team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants