Skip to content

Json test output formatter should represents "test_count" as a json string instead of a number #53866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cwndrws opened this issue Aug 31, 2018 · 1 comment · Fixed by #53867
Closed

Json test output formatter should represents "test_count" as a json string instead of a number #53866

cwndrws opened this issue Aug 31, 2018 · 1 comment · Fixed by #53867
Labels
A-libtest Area: `#[test]` / the `test` library T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@cwndrws
Copy link

cwndrws commented Aug 31, 2018

The output of a test suite starting when using the json formatter represents "test_count" as a json string, like so:

{ "type": "suite", "event": "started", "test_count": "1" }

I would expect it to be a number like this:

{ "type": "suite", "event": "started", "test_count": 1 }
@cwndrws cwndrws mentioned this issue Aug 31, 2018
Merged
@cwndrws
Copy link
Author

cwndrws commented Aug 31, 2018

It also seems like "filtered_out" on run finish is also unexectedly a string.

@cuviper cuviper added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-libtest Area: `#[test]` / the `test` library labels Aug 31, 2018
bors added a commit that referenced this issue Sep 5, 2018
@bors
Auto merge of #53867 - cwndrws:json-test-formatter-test-count-as-num,…
b0297f3 
… r=nrc

Make json test output formatter represent "test_count" as num

fixes #53866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-libtest Area: `#[test]` / the `test` library T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make json test output formatter represent "test_count" as num cwndrws/rust
2 participants
@cuviper @cwndrws