-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Description
Lines 57 to 58 in 7ac0200
static HOOK_LOCK: RWLock = RWLock::new(); | |
static mut HOOK: Hook = Hook::Default; |
looking at these two lines of code is very frightening.
Is there a specific reason to use RWLock
instead of RwLock
? I would open a PR with either using RwLock
or a comment describing why RWLock
is needed here.
@rustbot modify labels: T-libs
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.