Skip to content

rls no longer builds after rust-lang/rust#60827 #61240

@rust-highfive

Description

@rust-highfive
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #60827, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @oli-obk, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @nnethercote, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

Activity

added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on May 27, 2019
saifali96

saifali96 commented on May 27, 2019

@saifali96

@rust-highfive I just tried to update my rustc nightly, it breaks and says rls component is not available:

PS D:\work\rustexps\Rocket> rustup update
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: syncing channel updates for 'nightly-x86_64-pc-windows-msvc'
info: latest update on 2019-05-27, rust version 1.36.0-nightly (5187be620 2019-05-26)
error: component 'rls' for target 'x86_64-pc-windows-msvc' is unavailable for download for channel 'nightly'

Could the issue be also related to this one?

oli-obk

oli-obk commented on May 28, 2019

@oli-obk
Contributor

yes, very much related. I had a fix yesterday, but it didn't get through in time for todays nightly. Try again tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @oli-obk@Xanewok@saifali96@rust-highfive

    Issue actions

      `rls` no longer builds after rust-lang/rust#60827 · Issue #61240 · rust-lang/rust