Skip to content

rustdoc --check-theme doesn't work with minified theme #69071

@Nemo157

Description

@Nemo157
Contributor

In any crate running cargo doc && rustdoc --check-theme target/doc/light.css will emit a bunch of errors. If you take the css file and run it through something like prettier to get it to an unminified state then --check-theme will work fine.

Testing some manual minification of it one thing it appears to not like is , without a trailing space. Joining the h1, h2, lines into h1,h2, gives

  Missing "h1, h2, h3:not(.impl):not(.method):not(.type):not(.tymethod), h4:not(.method):not(.type):not(.tymethod)" rule

(cc @GuillaumeGomez)

Activity

added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
on Feb 12, 2020
added a commit that references this issue on Feb 12, 2020
839adda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

C-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @Nemo157@GuillaumeGomez

    Issue actions

      rustdoc --check-theme doesn't work with minified theme · Issue #69071 · rust-lang/rust