-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Closed
Labels
A-prettyArea: Pretty printing (including `-Z unpretty`)Area: Pretty printing (including `-Z unpretty`)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
E.g. printing ty::Slice(ty)
uses:
p!(write("["), print(ty), write("]"))
but we could allow writing it like this, by letting the macro use $...:literal
:
p!("[", print(ty), "]")
But I'm not sure the macro can handle it easily.
Maybe we should just have Print
implemented for more types and just make p!(a, b, c)
print a
, b
and c
(and we can then rename it to print!
).
This issue has been assigned to @jakevossen5 via this comment.
estebank
Metadata
Metadata
Assignees
Labels
A-prettyArea: Pretty printing (including `-Z unpretty`)Area: Pretty printing (including `-Z unpretty`)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
jakevossen5 commentedon Apr 11, 2020
@rustbot claim
Alexendoo commentedon Aug 5, 2020
Hi @jakevossen5, are you still working on this issue?
jakevossen5 commentedon Aug 5, 2020
So sorry for the lack of communication on this. I am, have gotten a bit busy this summer but have some stuff wrapping up and hope to get it done soon. If this is blocking or causing problems, then someone else can take it but if not I would still like to work on this.
Alexendoo commentedon Aug 5, 2020
No problem @jakevossen5, it's not blocking anything I'm just checking claimed issues to see if people are still interested in working on them
Rollup merge of rust-lang#77190 - jakevossen5:master, r=eddyb