Skip to content

TAIT: Add a test case using Sized #71085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Centril opened this issue Apr 13, 2020 · 2 comments · Fixed by #71103
Closed

TAIT: Add a test case using Sized #71085

Centril opened this issue Apr 13, 2020 · 2 comments · Fixed by #71103
Assignees
@rustbot
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Apr 13, 2020 •
edited by rustbot
Loading

Note to self (or whoever wants to help out); the following should be added as a test case in src/test/ui/type-alias-impl-trait:

// check-pass

#![feature(type_alias_impl_trait)]

type A = impl Sized;
fn f1() -> A { 0 }

type B = impl ?Sized;
fn f2() -> &'static B { &[0] }

type C = impl ?Sized + 'static;
fn f3() -> &'static C { &[0] }

type D = impl ?Sized;
fn f4() -> &'static D { &1 }

This issue has been assigned to @samrat via this comment.
@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` labels Apr 13, 2020
@samrat
Copy link
Contributor

samrat commented Apr 13, 2020

Hi, I would like to work on this.

@Centril
Copy link
Contributor Author

Centril commented Apr 13, 2020

@rustbot assign @samrat

@rustbot rustbot self-assigned this Apr 13, 2020
@samrat samrat mentioned this issue Apr 13, 2020
Merged
@bors bors closed this as completed in e261ef0 Apr 14, 2020
@oli-obk oli-obk moved this from Todo to Done in type alias impl trait stabilization Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
type alias impl trait stabilization
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test case for type aliasing impl Sized samrat/rust
3 participants
@samrat @Centril @rustbot