Skip to content

mir-opt/instrument_coverage.rs test needs profiler support #75735

@tesuji

Description

@tesuji
Contributor

mir-opt/instrument_coverage.rs test needs profiler support:

// needs-profiler-support

However, profiler is disable by default:
#profiler = false

So when the test failed I can't notice it in my machine.

P/S: Does profiler need support from LLVM ? I am using local LLVM if that count.

Originally posted by @lzutao in #75670 (comment)

Activity

added
A-code-coverageArea: Source-based code coverage (-Cinstrument-coverage)
and removed
A-self-profileArea: Self-profiling feature of the compiler
on Jan 22, 2021
added
A-testsuiteArea: The testsuite used to check the correctness of rustc
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Dec 16, 2023
Enselic

Enselic commented on Dec 28, 2024

@Enselic
Member

Triage: If the problem is that it's disabled by default, what's the problem with enabling it in your local config?

tesuji

tesuji commented on Dec 28, 2024

@tesuji
ContributorAuthor

I have no ideal about this issue since then.
I'd close this issue in this case.

Enselic

Enselic commented on Dec 28, 2024

@Enselic
Member

Thanks for getting back, let's close as obsolete then.

jieyouxu

jieyouxu commented on Dec 28, 2024

@jieyouxu
Member

That test no longer has //@ needs-profiler-suppport, FTR

//@ compile-flags: -Cinstrument-coverage -Zno-profiler-runtime

thanks to -Zno-profiler-runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-code-coverageArea: Source-based code coverage (-Cinstrument-coverage)A-testsuiteArea: The testsuite used to check the correctness of rustcT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Enselic@wesleywiser@tesuji@camelid@jieyouxu

        Issue actions

          `mir-opt/instrument_coverage.rs` test needs profiler support · Issue #75735 · rust-lang/rust