-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Not planned
Labels
A-code-coverageArea: Source-based code coverage (-Cinstrument-coverage)Area: Source-based code coverage (-Cinstrument-coverage)A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
mir-opt/instrument_coverage.rs
test needs profiler support:
// needs-profiler-support |
However, profiler is disable by default:
Line 220 in 5f6fcad
#profiler = false |
So when the test failed I can't notice it in my machine.
P/S: Does profiler need support from LLVM ? I am using local LLVM if that count.
Originally posted by @lzutao in #75670 (comment)
Metadata
Metadata
Assignees
Labels
A-code-coverageArea: Source-based code coverage (-Cinstrument-coverage)Area: Source-based code coverage (-Cinstrument-coverage)A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
Enselic commentedon Dec 28, 2024
Triage: If the problem is that it's disabled by default, what's the problem with enabling it in your local config?
tesuji commentedon Dec 28, 2024
I have no ideal about this issue since then.
I'd close this issue in this case.
Enselic commentedon Dec 28, 2024
Thanks for getting back, let's close as obsolete then.
jieyouxu commentedon Dec 28, 2024
That test no longer has
//@ needs-profiler-suppport
, FTRrust/tests/mir-opt/coverage/instrument_coverage.rs
Line 6 in 3c1e750
thanks to
-Zno-profiler-runtime
.