Skip to content

RFC: Is task::unkillable really unsafe? #7832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bblum opened this issue Jul 16, 2013 · 1 comment
Closed

RFC: Is task::unkillable really unsafe? #7832

bblum opened this issue Jul 16, 2013 · 1 comment
Labels
A-concurrency Area: Concurrency C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@bblum
Copy link
Contributor

bblum commented Jul 16, 2013

I think probably no. I am implementing the indestructible spawn mode, and if unkillable is unsafe, all the indestructible spawn functions should also be unsafe. But the worst thing that can happen these days with unkillable is unexpected process hangs, and deadlocks definitely aren't unsafe.
@ghost ghost assigned bblum Jul 16, 2013
@brson
Copy link
Contributor

brson commented Jul 17, 2013

Not unsafe.

bblum added a commit to bblum/rust that referenced this issue Jul 30, 2013
@bblum
Unkillable is not unsafe. Close rust-lang#7832.
a0d42bb
@bblum bblum closed this as completed in fa8102a Jul 31, 2013
@bblum bblum removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 21, 2021
@bors
Auto merge of rust-lang#7832 - narpfel:implicit-saturating-sub-false-…
af85240 
…positive-else, r=giraffate

Fix false positive of `implicit_saturating_sub` with `else` clause

Fixes rust-lang#7831

changelog: Fix false positive of [`implicit_saturating_sub`] with `else` clause
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-concurrency Area: Concurrency C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @bblum