-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
There is some rustdoc-related code in compiletest that uses the diff
command-line tool; however, it passes the --color
flag to diff
, which diff
does not accept on my system (macOS). We should probably use git diff --no-index
instead of diff
since it will have colors and will automatically use a pager. We may also want to pass the --minimal
flag to diff
/git diff
; the manual page says:
--minimal
Spend extra time to make sure the smallest possible diff is produced.
See also #79991 (comment).
cc @jyn514
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
jyn514 commentedon Mar 24, 2021
@camelid was this fixed by #82469 ?
notriddle commentedon Mar 25, 2021
Yeah, it looks like it's fixed.