Skip to content

add mut_slice_{to,from} for MutableVector in vec.rs #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bblum opened this issue Jul 26, 2013 · 3 comments
Closed

add mut_slice_{to,from} for MutableVector in vec.rs #8066

bblum opened this issue Jul 26, 2013 · 3 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented Jul 26, 2013

No description provided.

@recrack
Copy link
Contributor

recrack commented Jul 27, 2013

@bblum May i take this one?

@thestinger
Copy link
Contributor

@recrack: I actually have implementations of these in a branch already.

@recrack
Copy link
Contributor

recrack commented Jul 27, 2013

@thestinger Ok. i see. :)

flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 17, 2021
@bors
Auto merge of rust-lang#8066 - rust-lang:needless_bool_parenthesize, …
9e08527 
…r=camsteffen

Parenthesize blocks in `needless_bool` suggestion

Because the `if .. {}` statement already puts the condition in expression scope, contained blocks would be parsed as complete
statements, so any `&` binary expression whose left operand ended in a block would lead to a non-compiling suggestion.

We identify such expressions and add parentheses. Note that we don't make a difference between normal and unsafe blocks because the parsing problems are the same for both.

This fixes rust-lang#8052.

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@recrack @thestinger @bblum