Skip to content

regression 1.50: Code breaks due to newly stabalized std lib methods Ord::clamp and bool::then #80950

Closed
@rylev

Description

@rylev
Member

Two newly stabalized APIs (Ord::clamp and bool::then) caused regressions in crates due to their stabalization in the latest crater run. In total 4 crates were impacted by this.

This is likely to be closed with wont-fix, but I wanted to ensure it was noted somewhere.

@rustbot modify labels: +regression-from-stable-to-beta

Activity

added
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Jan 12, 2021
added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Jan 13, 2021
apiraino

apiraino commented on Jan 14, 2021

@apiraino
Contributor

Issue has been mentioned and noted in the latest crater run, so it will tracked there.

removed
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Jan 14, 2021
added this to the 1.50.0 milestone on Jan 14, 2021
scottmcm

scottmcm commented on Jan 14, 2021

@scottmcm
Member

clamp is almost certainly wont-fix as being expected -- Ord::clamp was backed out back in 2017 for breakage, so it finally stabilizing now seems like acceptance of this (allowed) breakage.

Mark-Simulacrum

Mark-Simulacrum commented on Jan 21, 2021

@Mark-Simulacrum
Member

Closing as expected and acceptable breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @rylev@Mark-Simulacrum@apiraino@scottmcm@rustbot

        Issue actions

          regression 1.50: Code breaks due to newly stabalized std lib methods `Ord::clamp` and `bool::then` · Issue #80950 · rust-lang/rust