rustpkg hangs during check-stage1 on Mac

[pnkfelix]

on my mac, when I do a make check-full, the process hangs during a test of rustpkg: here's how far it gets (illustrated via remake make debugger's --trace option):

% remake check-full --trace
...
             /Users/pnkfelix/Dev/Mozilla/rust-patch7081/mk/tests.mk:425 File `check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rust-exec' does not exist.
            /Users/pnkfelix/Dev/Mozilla/rust-patch7081/mk/tests.mk:425  Must remake target `check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rust-exec'.
            /Users/pnkfelix/Dev/Mozilla/rust-patch7081/mk/tests.mk:425  Successfully remade target file `check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rust-exec'.
             /Users/pnkfelix/Dev/Mozilla/rust-patch7081/mk/tests.mk:425 File `check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rustpkg-exec' does not exist.
               /Users/pnkfelix/Dev/Mozilla/rust-patch7081/mk/tests.mk:425   File `tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rustpkg.ok' does not exist.
              /Users/pnkfelix/Dev/Mozilla/rust-patch7081/mk/tests.mk:425    Must remake target `tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rustpkg.ok'.
Invoking recipe from /Users/pnkfelix/Dev/Mozilla/rust-patch7081/mk/tests.mk:425 to update target `tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rustpkg.ok'.
##>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
echo  run: x86_64-apple-darwin/stage1/test/rustpkgtest-x86_64-apple-darwin
##<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
run: x86_64-apple-darwin/stage1/test/rustpkgtest-x86_64-apple-darwin
##>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
x86_64-apple-darwin/stage1/test/rustpkgtest-x86_64-apple-darwin  --logfile tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rustpkg.log --test --bench --save-metrics tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rustpkg-metrics.json && touch tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rustpkg.ok
##<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

running 28 tests
test tests::no_rebuilding ... ignored
test tests::no_rebuilding_dep ... ignored
test tests::package_script_with_default_build ... ignored
test tests::rust_path_test ... ignored
test tests::rustpkg_install_url_2 ... ignored
test tests::test_build_hooks ... ignored
test tests::test_info ... ignored
test tests::test_rustpkg_test ... ignored
test tests::test_uninstall ... ignored
test tests::test_versions ... ignored
note: Fetching package: git clone https://bogus /var/folders/h_/0p2xs4r508b6533jj81hl4j40000gn/T/H2E4VEtzdYR1DAattest/src/bogus-0.1 ~[]
note: fetching https://bogus failed: can't clone repository
note: Couldn't infer any crates to build.
Try naming a crate `main.rs`, `lib.rs`, `test.rs`, or `bench.rs`.
note: Fetching package: git clone https://bogus /var/folders/h_/0p2xs4r508b6533jj81hl4j40000gn/T/H2E4VEtzdYR1DAattest/src/bogus-0.1 ~[]
note: fetching https://bogus failed: can't clone repository
rust: ~"~\"built_executable_in_workspace: /var/folders/h_/0p2xs4r508b6533jj81hl4j40000gn/T/H2E4VEtzdYR1DAattest/build/bogus/bogus does not exist\""
warning: library_in_workspace didn't find a library in /var/folders/h_/0p2xs4r508b6533jj81hl4j40000gn/T/H2E4VEtzdYR1DAattest/build/bogus for bogus
test tests::test_install_invalid ... ok

and then its hung there for hours.

(caveat: the above run was done on a version of the repository that's been slightly refactored, namely in the syntax::visit code; the merge-base for the refactoring and master is: 0012b50)

[catamorphism]

I have a fixed, it's just not checked in yet.

[catamorphism]

This should be fixed now, but I'm running make check-stage1-rustpkg on my machine just to be sure.

[catamorphism]

Works for me now. I believe the problem was #7925.