-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-mir-optArea: MIR optimizationsArea: MIR optimizationsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.
Description
Ever since our mir-opt tests were changed to auto-blessing, we no longer have a way to say "but this part of the output must definitely look like that". This makes tests a lot more fragile. We should re-add some infrastructure like that.
LLVM has FileCheck for this. We also had something like that for mir-opt tests that we could reinstate (I think it was adequate for this job, it just didn't work well for large chunks of code).
Cc @rust-lang/wg-mir-opt
wesleywiser
Metadata
Metadata
Assignees
Labels
A-mir-optArea: MIR optimizationsArea: MIR optimizationsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
oli-obk commentedon May 11, 2021
The old system was removed in d0e0f40#diff-03a0567fa80ca04ed5a55f9ac5c711b4f84659be2d0ac4a984196d581c04f76b, so we should be able to revert that commit with some minor adjustments
Rollup merge of rust-lang#116810 - cjgillot:mir-opt-check, r=oli-obk
Auto merge of rust-lang#116810 - cjgillot:mir-opt-check, r=oli-obk