Skip to content

Ensure that hasClass is correctly used #85450

New issue
New issue
Closed
Closed
Ensure that hasClass is correctly used#85450
Assignees
GuillaumeGomez
Labels
A-rustdoc-jsArea: Rustdoc's JS front-endC-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
@GuillaumeGomez

Description

@GuillaumeGomez
GuillaumeGomez
opened on May 18, 2021 · edited by GuillaumeGomez
Member

As discovered in #85438, hasClass returns false when the element doesn't exist (which is normal) but that means we have to check if the element exist beforehand sometimes too.

Activity

GuillaumeGomez
added
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
A-rustdoc-jsArea: Rustdoc's JS front-end
on May 18, 2021
GuillaumeGomez
self-assigned this
on May 18, 2021
GuillaumeGomez
mentioned this on May 19, 2021
jsha

jsha commented on May 22, 2021

@jsha
jsha
on May 22, 2021
Contributor

Resolved by closing the linked PR.

jsha
closed this as completedon May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-rustdoc-jsArea: Rustdoc's JS front-endC-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @jsha@GuillaumeGomez

    Issue actions
      Ensure that hasClass is correctly used · Issue #85450 · rust-lang/rust