Skip to content

Add debugging flag to assert state of incremental cache #85864

Closed
@Aaron1011

Description

@Aaron1011
Member

In PR #85702, I added a test that relies on the incremental cache still being saved if a linker error occurs. It would be good for the test to assert that this assumption is actually true. We could add a new flag -Z assert-incr-state=<state>, where <state> can be:

  • none - we didn't find any previous session dirs whatsoever
  • mismatch - we found an existing session dir, but did not load it to do a command-line arg hash mismatch.
  • loaded - we found and loaded an existing session dir. Note that this says nothing about whether any particular query will be found to be red or green.

Activity

added
A-incr-compArea: Incremental compilation
C-enhancementCategory: An issue proposing an enhancement or a PR with one.
on May 31, 2021
Mark-Simulacrum

Mark-Simulacrum commented on May 31, 2021

@Mark-Simulacrum
Member

It'd be good to add these flags to rustc-perf's incr tests once this flag is implemented, I think, FWIW.

pierwill

pierwill commented on Oct 26, 2021

@pierwill
Member

@rustbot claim

added a commit that references this issue on Nov 18, 2021

Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…

a4739f2
added 3 commits that reference this issue on Nov 18, 2021

Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…

682a636

Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…

b8a9cd4

Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…

728b3f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-incr-compArea: Incremental compilationA-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @Aaron1011@jonas-schievink@Mark-Simulacrum@pierwill

    Issue actions

      Add debugging flag to assert state of incremental cache · Issue #85864 · rust-lang/rust