Closed
Description
In PR #85702, I added a test that relies on the incremental cache still being saved if a linker error occurs. It would be good for the test to assert that this assumption is actually true. We could add a new flag -Z assert-incr-state=<state>
, where <state>
can be:
none
- we didn't find any previous session dirs whatsoevermismatch
- we found an existing session dir, but did not load it to do a command-line arg hash mismatch.loaded
- we found and loaded an existing session dir. Note that this says nothing about whether any particular query will be found to be red or green.
Activity
Vec
before computing itsDepTrackingHash
#85702Mark-Simulacrum commentedon May 31, 2021
It'd be good to add these flags to rustc-perf's incr tests once this flag is implemented, I think, FWIW.
pierwill commentedon Oct 26, 2021
@rustbot claim
-Zassert-incr-state
to assert state of incremental cache #90386Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…
Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…
Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…
Rollup merge of rust-lang#90386 - pierwill:assert-incr-state-85864, r…
-Zassert-incr-state
flag to incremental tests rust-lang/rustc-perf#1131