-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.D-papercutDiagnostics: An error or lint that needs small tweaks.Diagnostics: An error or lint that needs small tweaks.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Today I hit this issue: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=fdce0c73a1c1190a8bd4a82c5cc24b52
but I couldn't for the life of me see the difference in the methods.
In some places, rust suggests differences that are short Levenshtein distance from each other, can that be done here as well?
maansinga
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.D-papercutDiagnostics: An error or lint that needs small tweaks.Diagnostics: An error or lint that needs small tweaks.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
hellow554 commentedon Jun 3, 2021
It's done for structs and their fields/methods, but not for traits, e.g.:
If you would implement this for traits, there's a good chance that you might get a lof of false positives, but I can see your point, so I think this should be implemented! :)
guswynn commentedon Jun 3, 2021
@hellow554 for calling trait methods I agree, we should be careful about false-positives, but this issue is more specifically about impl-blocks for traits, where we know the exact list of required methods to implement to compare to
hellow554 commentedon Jun 3, 2021
Ah! Yes! You're absolutely right! That's a great thing to do :D
hkmatsumoto commentedon Sep 25, 2021
@rustbot claim
Rollup merge of rust-lang#89248 - hkmatsumoto:suggest-similarly-named…
Rollup merge of rust-lang#89248 - hkmatsumoto:suggest-similarly-named…
Rollup merge of rust-lang#89248 - hkmatsumoto:suggest-similarly-named…