Skip to content

Deduplicate doc tests logic #86254

Closed
@GuillaumeGomez

Description

@GuillaumeGomez
Member

This comes from a discussion in #86230: for the moment, we call libtest from two places: markdown.rs (which is used when we provide a markdown file as input) and doctest.rs (when a rust file is provided as input, the default).

Both calls can be found when grepping with testing::test_main(.

Activity

camelid

camelid commented on Jun 12, 2021

@camelid
Member

Probably the deduplicated logic should go in doctest.rs.

added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
and removed on Jun 22, 2021
added 2 commits that reference this issue on Jul 23, 2021

Rollup merge of rust-lang#87372 - GuillaumeGomez:move-test_main-calls…

ffd0a3c

Rollup merge of rust-lang#87372 - GuillaumeGomez:move-test_main-calls…

7c2436a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-doctestsArea: Documentation tests, run by rustdocC-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @GuillaumeGomez@jyn514@camelid

      Issue actions

        Deduplicate doc tests logic · Issue #86254 · rust-lang/rust